Remove __fututure__ import for type hints#245
Merged
Conversation
Serhiy1
force-pushed
the
dev/serhiy/typehint-cleanup
branch
from
9294c66 to
c9edd63
Compare
eccles
approved these changes
Jul 28, 2023
- the python committee has decided that __annotations__ is not the correct way to deal with cyclical dependencies
Serhiy1
force-pushed
the
dev/serhiy/typehint-cleanup
branch
from
c9edd63 to
8df083c
Compare
eccles
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed as the python committee decided that annotations is not the correct way to deal with cyclical imports
Convert necessary type hints to strings to deal with the removal of the import